Handle empty hand slots properly #2

Merged

max merged 1 commit from timotree/deck-website:null-cards into main

2025-08-14 22:01:13 +02:00

timotree commented

2025-08-14 21:22:35 +02:00

Collaborator

Empty slots in the hand are now represented by a null card. I carefully checked every use of state.hand to make sure this is accounted for properly.

Fixes bugs where:

Styles are not removed when a card becomes an empty slot.
Importing a game crashes when it contains an action on a slot to the right of an empty slot.
Updating the DOM crashes when a player clues and the next player's leftmost slot is empty.
- In order to fix this, I changed the default rank clue to be the highest rank, rather than the rank of their leftmost slot.

Empty slots in the hand are now represented by a `null` card. I carefully checked every use of `state.hand` to make sure this is accounted for properly. Fixes bugs where: - Styles are not removed when a card becomes an empty slot. - Importing a game crashes when it contains an action on a slot to the right of an empty slot. - Updating the DOM crashes when a player clues and the next player's leftmost slot is empty. - In order to fix this, I changed the default rank clue to be the highest rank, rather than the rank of their leftmost slot.

timotree added 1 commit

2025-08-14 21:22:36 +02:00

Handle empty hand slots properly 8269ed8b62

Empty slots in the hand are now represented by a `null` card.
I carefully checked every use of `state.hand` to make sure this is accounted for properly.
Fixes bugs where:
- Styles are not removed when a card becomes an empty slot.
- Importing a game crashes when it contains an action on a slot to the right of an empty slot.
- Updating the DOM crashes when a player clues and the next player's leftmost slot is empty.
  - In order to fix this, I changed the default rank clue to be the highest rank,
    rather than the rank of their leftmost slot.